You wont have to bother with HandleObject or RootedObject etc. These are internal to js/ and we take care of these cases. Just use JS::Handle<JSObject*> or JS::Rooted<JSObject*>. Thanks for pointing people to this file.
PS: The correct handle for Jon Coppeard is of course jonco! On Tue, Apr 23, 2013 at 3:58 PM, smaug <sm...@welho.com> wrote: > On 04/23/2013 04:07 PM, Tom Schuster wrote: >> >> At the moment it's really just Jono working full time on this, and >> terrence and other people reviewing. This stuff is actually quite easy >> and you can expect really fast review times from our side. >> >> In some parts of the code rooting could literally just mean to replace >> JS::Value to JS::RootedValue and fixing the references to the >> variable. It's really easy once you did it a few times. >> >> Here is a list of all files that still have rooting problems: >> http://pastebin.mozilla.org/2340241 >> And the details for each and every problem: >> https://people.mozilla.com/~sfink/analysis/browser/rootingHazards.txt >> >> We are using https://bugzilla.mozilla.org/show_bug.cgi?id=831379 to >> track the rooting progress, make sure to file every bug as blocking >> this one. I would appreciate if every module peer or owner would just >> take a look at his/her module and tried to fix some of the issue. If >> you are unsure or need help, ask us on #jsapi. >> >> Thanks, >> Tom >> > > I found http://mxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h > quite useful, but there are few things to > clarify. For example some code uses HandleObject and some code > Handle<JSObject*> and having two ways to do the same thing > just makes the code harder to read. > > >> On Tue, Apr 23, 2013 at 3:03 AM, Robert O'Callahan <rob...@ocallahan.org> >> wrote: >>> >>> On Tue, Apr 23, 2013 at 5:36 AM, Terrence Cole <tc...@mozilla.com> wrote: >>> >>>> Our exact rooting work is at a spot right now where we could easily use >>>> more hands to accelerate the process. The main problem is that the work >>>> is easy and tedious: a hard sell for pretty much any hacker at mozilla. >>>> >>> >>> It sounds worthwhile to encourage developers who aren't currently working >>> on critical-path projects to pile onto the exact rooting project. Getting >>> GGC over the line reaps some pretty large benefits and it's an >>> all-or-nothing project, unlike say pursuing the long tail of WebIDL >>> conversions. >>> >>> If that sounds right, put out a call for volunteers (by which I include >>> paid staff) to help push on exact rooting, with detailed instructions. I >>> know some people who could probably help. >>> >>> Rob >>> -- >>> q“qIqfq qyqoquq qlqoqvqeq qtqhqoqsqeq qwqhqoq qlqoqvqeq qyqoquq,q >>> qwqhqaqtq >>> qcqrqeqdqiqtq qiqsq qtqhqaqtq qtqoq qyqoquq?q qEqvqeqnq qsqiqnqnqeqrqsq >>> qlqoqvqeq qtqhqoqsqeq qwqhqoq qlqoqvqeq qtqhqeqmq.q qAqnqdq qiqfq qyqoquq >>> qdqoq qgqoqoqdq qtqoq qtqhqoqsqeq qwqhqoq qaqrqeq qgqoqoqdq qtqoq >>> qyqoquq,q >>> qwqhqaqtq qcqrqeqdqiqtq qiqsq qtqhqaqtq qtqoq qyqoquq?q qEqvqeqnq >>> qsqiqnqnqeqrqsq qdqoq qtqhqaqtq.q" >>> _______________________________________________ >>> dev-platform mailing list >>> dev-platform@lists.mozilla.org >>> https://lists.mozilla.org/listinfo/dev-platform > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
