Developers,
This week I plan to remove blank lines at the beginnings and ends of JS
blocks and update the global eslint configuration file to prohibit them
by landing the patch in bug 1518283
<https://bugzilla.mozilla.org/show_bug.cgi?id=1518283>.
Note that I'm not removing all blank lines, only those at the beginnings
and ends of blocks, which eslint calls padded-blocks
<https://eslint.org/docs/rules/padded-blocks>.
Most JS blocks in the tree are already unpadded, and we already prohibit
padded blocks in a number of subdirectories
<https://searchfox.org/mozilla-central/search?q=padded-blocks>.
Prohibiting them tree-wide is consistent with Mark Banner's plan for
eslint rule harmonization
<https://www.thebanners.uk/standard8/2018/10/03/whats-next-for-eslint-on-firefox-source-code/>.
The patch may conflict with other patches-in-progress, given my
experience maintaining a branch with the changes over the last few
weeks. However, the conflict resolution is straightforward, since the
only change being made is the removal of entirely blank lines. And
annotation (blame) views of the codebase are unaffected, since removed
lines don't show up there.
Let me know if you have any questions or concerns.
Cheers,
-myk
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
