Hi Martin!
Thanks for the reply.
Yes, of course I can file a bug report for that. I guess I should
finish the patch first?
For two days now, I see a different build failure though:
gcc -o NetBSD7.99.26_64_OPT.OBJ/tls13hkdf.o -c -O -fPIC -DPIC -ansi -Wall
-Wno-switch -pipe -DNETBSD -Dunix -DHAVE_STRERROR -DHAVE_BSD_FLOCK -Wall
-Werror -DXP_UNIX -UDEBUG -DNDEBUG -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT
-DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DNSS_ENABLE_SSL_ZLIB
-I/usr/pkg/include/nspr -I/usr/X11R6/include
-I./../dist/NetBSD7.99.26_64_OPT.OBJ/include -I./../dist/public/
-I./../dist/private/ -I/usr/X11R6/include
-I../../dist/NetBSD7.99.26_64_OPT.OBJ/include -I../../dist/public/
-I../../dist/private/ -I/usr/X11R6/include
-I../../../dist/NetBSD7.99.26_64_OPT.OBJ/include -I../../../dist/public/nss
-I../../../dist/private/nss tls13hkdf.c
tls13hkdf.c:15:1: error: expected identifier or '(' before '/' token
// TODO(e...@rtfm.com): Export this separately.
^
tls13hkdf.c:15:12: error: stray '@' in program
// TODO(e...@rtfm.com): Export this separately.
^
tls13hkdf.c: In function 'tls13_HkdfExpandLabel':
tls13hkdf.c:136:5: error: implicit declaration of function 'tls13_EncodeUintX'
[-Werror=implicit-function-declaration]
ptr = tls13_EncodeUintX(keySize, 2, ptr);
^
tls13hkdf.c:136:9: error: assignment makes pointer from integer without a cast
[-Werror]
ptr = tls13_EncodeUintX(keySize, 2, ptr);
^
tls13hkdf.c:137:9: error: assignment makes pointer from integer without a cast
[-Werror]
ptr = tls13_EncodeUintX(labelLen + kLabelPrefixLen, 1, ptr);
^
tls13hkdf.c:142:9: error: assignment makes pointer from integer without a cast
[-Werror]
ptr = tls13_EncodeUintX(handshakeHashLen, 1, ptr);
^
cc1: all warnings being treated as errors
Thomas
On Mon, Feb 01, 2016 at 11:15:14AM +1100, Martin Thomson wrote:
> Hi Thomas,
>
> Do you think that you could push these patches to bugzilla? See
> https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS&component=Libraries
>
> And it would be easier to review this as a single patch, I think,
> since all the changes are fairly simple.
>
> On Sat, Jan 30, 2016 at 11:40 PM, Thomas Klausner <t...@giga.or.at> wrote:
> > Hi!
> >
> > Recently nss turned on -Werror by default for all platforms. I think
> > that's a good idea. However, it majorly broke the build on NetBSD with
> > lots of these types of messages:
> >
> > certcgi.c: In function 'MakeNameConstraints':
> > certcgi.c:1654:6: error: array subscript has type 'char'
> > [-Werror=char-subscripts]
> >
> > The reason is that NetBSD is very picky about the use of the ctype
> > functions. To cite the man page ctype(3):
> >
> > CAVEATS
> > The first argument of these functions is of type int, but only a very
> > restricted subset of values are actually valid. The argument must
> > either
> > be the value of the macro EOF (which has a negative value), or must be
> > a
> > non-negative value within the range representable as unsigned char.
> > Passing invalid values leads to undefined behavior.
> >
> > Values of type int that were returned by getc(3), fgetc(3), and similar
> > functions or macros are already in the correct range, and may be safely
> > passed to these ctype functions without any casts.
> >
> > Values of type char or signed char must first be cast to unsigned char,
> > to ensure that the values are within the correct range. Casting a
> > negative-valued char or signed char directly to int will produce a
> > negative-valued int, which will be outside the range of allowed values
> > (unless it happens to be equal to EOF, but even that would not give the
> > desired result).
> >
> >
> > I've started fixing these, attached is a first batch of patches. More
> > are needed, but I wanted to find out first how to make sure they get
> > applied.
> >
> > I'll also attach two patches for the included zlib. It doesn't compile
> > because of missing prototypes for read/write/close, so I added an
> > #include <unistd.h> in two places.
> >
> > Thanks,
> > Thomas
> >
> > --
> > dev-tech-crypto mailing list
> > dev-tech-crypto@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-tech-crypto
> --
> dev-tech-crypto mailing list
> dev-tech-crypto@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-tech-crypto
>
--
dev-tech-crypto mailing list
dev-tech-crypto@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-crypto
