Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/38
>> requireCommonBaseDir:
>> could we replace firstPath by base==null?
>> line 115: additional comment:
>> 'fail fast: ...'
>> line 117: 'finally we got ...'
Done and PR updated
>> getBaseDir:
>>
>> Rename parameter to file1 and file2. For me it seems that both
parameters are indepent from each other. 'base' implies that it's itself a
parent of the other.
You are right about that. So I changed the param names and updated the
javadoc too. Please have a look in the updated PR and let me know if it makes
sense now.
>> you changed the semantic of the method:
>> base==null && file==null --> old=NPE, new=null (ok with me ;)
>> base==null && file!=null --> old=file.paren, new=null (incompatible
change)
>> base!=null && file==null --> both=null
>> base!=null && file!=null --> both=commonBase
>> could be static, maybe moved to a FileUtil-class
When I started implementing the changes for this bug fix, I had a look at
this method and its references. In reality, this `getBaseDir` essentially
can/should be a private method. The only reason why it's package private right
now is to have access to this method in a test case. There are no other
references to this and given that this is a package private method, there's no
other way this method can be by any other (external) code then that specific
package. Given this background, I decided to intentionally make that
incompatible semantic change so that it now fits in with the expectations of
how we want it to behave. Do you think that should be good enough reason to go
ahead with this change in semantics of this method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
