Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129587968
--- Diff:
src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java
---
@@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(String name,
LatestStrategy strategy) {
if (versionMatcher.isDynamic(mrid)) {
while (iter.hasNext()) {
IvyNode other = iter.next();
- if (versionMatcher.isDynamic(other.getResolvedId())) {
+ if (versionMatcher.isDynamic(other.getResolvedId())
+ || !versionMatcher.accept(mrid,
other.getResolvedId())
+ && !handleIncompatibleConflict(parent, conflicts,
node, other)) {
--- End diff --
This change doesn't look right. The previous logic would have returned
`null` if the `versionMatcher.isDynamic` returned true. With this change, it
will require an additional `&&` to be satisfied for the
`!handlerIncompatibleConflict...`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
