jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1381175943
Thank you Tomasz for this PR. I think this change looks fine. Could you add a test case to verify this change works as expected. We have a junitlauncher test class at `src/tests/junit/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTaskTest.java` which uses the `src/etc/testcases/taskdefs/optional/junitlauncher.xml` as the build file to test. Perhaps you could add a new test method to it to try a test which times out intentionally after a few seconds? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
