From: "Jeff Trawick" <[EMAIL PROTECTED]>
Sent: Thursday, March 15, 2001 9:42 PM

> > No def files... please properly APR_DECLARE(rettype) apr_fn(args)
> > always and this doesn't become a problem again, ever.
> 
> hmmm... it was done properly to start with... I don't know why Ian was
> getting this error

Neither do I, except if he didn't clean before his last make.  I don't get
this error either.

> > > +#if !defined(EAFNOSUPPORT) && defined(WSAEAFNOSUPPORT)
> > > +#define EAFNOSUPPORT WSAEAFNOSUPPORT
> > > +#endif
> > > +
> > 
> > This needs to be APR_EAFNOSUPPORT and a status test, _please_ fix this
> > in the canonical errors header!  Then the APR_STATUS_IS_EAFNOSUPPORT()
> > on Win32 compares WSAEAFNOSUPPORT, and on OS2 it will do what OS2
> > does.
> 
> not tonight... dead code anyway...  maybe useful if EAFNOSUPPORT could
> be exposed to callers of APR

Doesn't need to be tonight, I just worry over these sorts of things :-)
With my last commit after the dbmmanage.in change, Win32 builds fine again.

Bill


Reply via email to