Joe,
I will mask this test ndef WIN32 for versions prior to 1.3.0, I agree
we won't be changing semantics and surrender to the fact that we failed
to make a portable library.
I am removing ALL per-platform tests on 1.3.0 forward that introspect
non-apr flags to determine OS behavior. Those tests *PROVE* non-portability
and therefore indicate errors in our API which must be addressed.
In a portability library, every condition that indicates a feature is not
supported needs to be reflected in a constant, or in an ENOTIMPL result from
invoking the unsupported function or feature.
If our test framework *works*, it is using strictly the apr behavior to
prove or disprove the validitity of the apr's API and feature set. Anything
else illustrates bad examples to our user/developers who then follow our lead.
Does this strike you as reasonable, moving -forwards-, and ignoring the
issue in 1.2.x and prior?
Bill
Joe Orton wrote:
On Fri, Feb 10, 2006 at 12:10:01AM -0000, William Rowe wrote:
Author: wrowe
Date: Thu Feb 9 16:09:59 2006
New Revision: 376501
URL: http://svn.apache.org/viewcvs?rev=376501&view=rev
Log:
This test can't be portably implemented until we define a symbol
to declare that apr_[ug]id_t is intregal, as opposed to the current
opaque definition on Win32.
Backports 376409
-1, please do not arbitrarily disable tests on all platforms just
because one platform is "special". Use #ifndef WIN32, as I said *twice*
already.
--- apr/apr/branches/1.2.x/test/testuser.c (original)
+++ apr/apr/branches/1.2.x/test/testuser.c Thu Feb 9 16:09:59 2006
@@ -94,6 +94,8 @@
apr_gid_compare(gid, retreived_gid));
}
+#ifdef APR_UID_GID_NUMERIC
+
static void fail_userinfo(abts_case *tc, void *data)
.
