On Sep 3, 2007, at 6:54 PM, William A. Rowe, Jr. wrote:

Please review and vote on those you have time to - reply once or four times,
just review those you can as you can; http://apr.apache.org/dev/dist/

Good signatures on all, good md5 checksums (but what did you do to get the upper case hash strings with the spaces between the bytes?).

Tested on MacOSX 10.4.10 on PowerPC, FreeBSD on an Intel Celeron and Ubuntu Breezy on a dual amd64.

  +1/-1   Release
   [+1]   apr-1.2.11
   [+1]   apr-util-1.2.10

See below for build weirdness on FreeBSD.

   [+1]   apr-0.9.16
   [+1]   apr-util-0.9.15

Details:

Darwin graymalkin.sandla.org 8.10.0 Darwin Kernel Version 8.10.0: Wed May 23 16:50:59 PDT 2007; root:xnu-792.21.3~1/RELEASE_PPC Power Macintosh powerpc
(Powerbook G4)

  +1/-1   Release
   [+1]   apr-1.2.11

All tests passed.

   [+1]   apr-util-1.2.10

make check completes without error.

   [+1]   apr-0.9.16

make check completes without error.

   [+1]   apr-util-0.9.15

make check completes without error.

FreeBSD bagheera.sandla.org. 6.2-STABLE FreeBSD 6.2-STABLE #6: Tue Jun 12 15:17:39 PDT 2007 [EMAIL PROTECTED]:/usr/obj/ usr/src/sys/BAGHEERA i386
(single Celeron)

  +1/-1   Release
   [+1]   apr-1.2.11

All tests passed.

   [-0]   apr-util-1.2.10

Build breaks on expat installation:

./configure --prefix=/tmp/12/inst --with-apr=/tmp/12/inst
<..>
checking Expat 1.95.x... no
checking old Debian-packaged expat... no
checking old FreeBSD-packaged expat... no
checking Expat 1.0/1.1... no
  setting LDFLAGS to "-L/usr/local/lib"
  adding "-I/usr/local/include" to CPPFLAGS
checking Expat 1.95.x in /usr/local... yes
  setting APRUTIL_INCLUDES to "-I/usr/local/include"
  setting APRUTIL_EXPORT_LIBS to "-lexpat"
  setting APRUTIL_LIBS to "-lexpat"
<..>
make
<..>
/usr/local/bin/bash /tmp/12/inst/build-1/libtool --silent -- mode=link gcc -g -O2 -DHAVE_CONFIG_H -I/tmp/12/build/apr- util-1.2.10/include -I/tmp/12/build/apr-util-1.2.10/include/private - I/tmp/12/inst/include/apr-1 -I/usr/local/include -version-info 2:11:2 -o libaprutil-1.la -rpath /tmp/12/inst/lib buckets/ apr_buckets_pipe.lo buckets/apr_buckets_flush.lo buckets/ apr_buckets_alloc.lo buckets/apr_buckets_pool.lo buckets/ apr_buckets_socket.lo buckets/apr_buckets_heap.lo buckets/ apr_buckets_simple.lo buckets/apr_buckets_file.lo buckets/ apr_buckets.lo buckets/apr_buckets_mmap.lo buckets/apr_buckets_eos.lo buckets/apr_brigade.lo buckets/apr_buckets_refcount.lo crypto/ apr_sha1.lo crypto/uuid.lo crypto/getuuid.lo crypto/apr_md5.lo crypto/ apr_md4.lo dbm/apr_dbm.lo dbm/apr_dbm_berkeleydb.lo dbm/ apr_dbm_gdbm.lo dbm/apr_dbm_ndbm.lo dbm/apr_dbm_sdbm.lo dbm/sdbm/ sdbm_pair.lo dbm/sdbm/sdbm.lo dbm/sdbm/sdbm_hash.lo dbm/sdbm/ sdbm_lock.lo encoding/apr_base64.lo hooks/apr_hooks.lo ldap/ apr_ldap_url.lo ldap/apr_ldap_option.lo ldap/apr_ldap_init.lo misc/ apr_reslist.lo misc/apu_version.lo misc/apr_date.lo misc/apr_rmm.lo misc/apr_queue.lo uri/apr_uri.lo xml/apr_xml.lo strmatch/ apr_strmatch.lo xlate/xlate.lo dbd/apr_dbd.lo dbd/apr_dbd_sqlite2.lo dbd/apr_dbd_sqlite3.lo dbd/apr_dbd_pgsql.lo -lcrypt -lpthread - lexpat -liconv /tmp/12/inst/lib/libapr-1.la -lcrypt -lpthread
/usr/bin/ld: cannot find -lexpat
*** Error code 1

Stop in /tmp/12/build/apr-util-1.2.10.
*** Error code 1

Stop in /tmp/12/build/apr-util-1.2.10.

The box has Expat 2.0.0 installed through ports:

[EMAIL PROTECTED] apr-util-1.2.10 $ pkg_info -L expat\*
Information for expat-2.0.0_1:

Files:
/usr/local/man/man1/xmlwf.1.gz
/usr/local/bin/xmlwf
/usr/local/include/expat.h
/usr/local/include/expat_external.h
/usr/local/lib/libexpat.a
/usr/local/lib/libexpat.la
/usr/local/lib/libexpat.so
/usr/local/lib/libexpat.so.6

The libexpat.so should be found for -lexpat, but it doesn't look like the -L/usr/local/lib (or any -L for that matter) made it into the link invocation. I don't know whether FreeBSD searches /usr/local/ lib by default.

But...

[EMAIL PROTECTED] apr-util-1.2.10 $ ldconfig -r
/var/run/ld-elf.so.hints:
search directories: /lib:/usr/lib:/usr/lib/compat:/usr/X11R6/ lib:/usr/local/lib:/usr/local/lib/compat/pkg:/usr/local/lib/mysql:/ usr/local/lib/pth
<..>
        201:-lexpat.6 => /usr/local/lib/libexpat.so.6
<..>
        275:-lexpat.5 => /usr/local/lib/compat/pkg/libexpat.so.5

So... wtf?

  [+1]   apr-0.9.16

This program won't work on this platform because there is no support for threads. This program won't work fully on this platform because there is no support for threads.
Failed
oldval =0 should be zero
Failed.
testing apr_atomic_dec *** Error code 255

Stop in /tmp/09/build/apr-0.9.16/test.
*** Error code 1

Stop in /tmp/09/build/apr-0.9.16.

The rest of APR supports threads on FreeBSD 6, so this breakage is bogus. Also, not a regression because it's been like that for ages.

   [+1]   apr-util-0.9.15

make check completes without error but does protest about lack of thread support. This mild brokenness of the tests won't stand in the way of my vote.

Linux ubuntu 2.6.15-28-amd64-server #1 SMP Tue Mar 13 21:03:51 UTC 2007 x86_64 GNU/Linux
(dual CPU amd64 box)

  +1/-1   Release
   [+1]   apr-1.2.11

All tests passed.

   [+1]   apr-util-1.2.10

make check completes without error.

   [+1]   apr-0.9.16

make check completes without error.

   [+1]   apr-util-0.9.15

make check completes without error.

S.

--
Sander Temme
[EMAIL PROTECTED]
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF



Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to