I think we should be a little bit more strict when it comes to resource
limits in reslist code. As per attached, it should not be possible to
set min to less than zero and hmax to zero, as both don't make sense.
Comments?
--
Bojan
Index: misc/apr_reslist.c
===================================================================
--- misc/apr_reslist.c (revision 680207)
+++ misc/apr_reslist.c (working copy)
@@ -245,7 +245,8 @@
/* Do some sanity checks so we don't thrash around in the
* maintenance routine later. */
- if (min > smax || min > hmax || smax > hmax || ttl < 0) {
+ if (min < 0 || min > smax || min > hmax || smax > hmax || hmax == 0 ||
+ ttl < 0) {
return APR_EINVAL;
}
