mlsorensen commented on code in PR #86:
URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595570927


##########
generate/generate.go:
##########
@@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{
        "updateAccount":    true,
 }
 
+// requiresPost is a prefilled set of API names that require POST
+// for security or size purposes
+var requiresPostMethod = map[string]bool{
+       "login":                            true,
+       "deployVirtualMachine":             true,
+       "updateVirtualMachine":             true,
+       "createUser":                       true,
+       "updateUser":                       true,
+       "addVpnUser":                       true,
+       "registerUserData":                 true,
+       "setupUserTwoFactorAuthentication": true,
+       "validateUserTwoFactorAuthenticationCode": true,

Review Comment:
   Correct, but they're calls that I wanted to ensure use post when and if they 
do get added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to