Carsten Ziegeler wrote:
Felix Knecht wrote:
The problem:
As far as I've seen, sitemap element parser as well as settings element
parser do not respect CLI property settings ( -Dorg.apache.cocoon.mode=xxx).
The duplication:
With my supposed patch the functions getSystemProperty(String key) and
getSystemProperty(String key, String defaultValue) are implemented
several times at different locations (I think to remember alsways as
protected).
Ok, I briefly looked at the current code (I have not looked at your
patch yet). The current code is not the original (working) code. The old
version did check the system property and the optional runningMode
attribute of the cocoon:settings element in the applicationContext,
both, in the settings element parser. And this was the only place where
this checking occured.
The sitemap element parser *always* gets the running mode set by the
attribute runningMode. This is ensured by the SitemapHelper class which
creates an in memory spring configuration containing the sitemap element.
Can I ask why this particular technique (I mean creating a string with
xml to pass it to application context constructor)?
--
Leszek Gawron CTO at MobileBox Ltd.
