[ 
https://issues.apache.org/jira/browse/COCOON3-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847796#action_12847796
 ] 

Simone Tripodi commented on COCOON3-54:
---------------------------------------

Hi Francesco, thanks a lot, very appreciated,
please take a look at below suggestions:
- for future patches you'll submit, follow 
http://commons.apache.org/patches.html that describes the Apache way to submit 
patches, otherwise merging code for more complicated stuff will become hard;
- add always the apache license header you can find on existing code;
- no more @author tags: committers and contributors are mentioned in the Team 
page.
Thanks in advance,
Simo


> LinkRewriterTransformer
> -----------------------
>
>                 Key: COCOON3-54
>                 URL: https://issues.apache.org/jira/browse/COCOON3-54
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-sax
>            Reporter: Francesco Chicchiriccò
>            Assignee: Simone Tripodi
>         Attachments: LinkRewriter.java, LinkRewriterTransformer.java, 
> LinkRewritingException.java
>
>
> A LinkRewriterTransformer (like as the old one for Cocoon 2.1, see [1]) could 
> be a very nice addendum to Cocoon 3.
> It could may even by an idea to have a LinkRewriterTransformer<T>, where T is 
> the class performing the actual transformation on links.
> [1] 
> http://cocoon.apache.org/2.1/apidocs/org/apache/cocoon/transformation/LinkRewriterTransformer.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to