[ https://issues.apache.org/jira/browse/COCOON-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561543#comment-15561543 ]
Francesco Chicchiriccò commented on COCOON-2352: ------------------------------------------------ Hi [~fortuna], thanks for your PR (which is also the very first coming from github, wow...)! As you can see from [1] (I had to download the PR as diff, then rework it a bit to make it compatible with Cocoon 2.1 JUnit tests [2]), your changes are now incorporated. I have also added [3] to properly handle XMLEncoder#highSurrogate re-initialization. Shall we close this issue, then? [1] http://svn.apache.org/viewvc?view=revision&revision=1764023 [2] http://cocoon.apache.org/2.1/installing/tests.html [3] http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/src/blocks/serializers/java/org/apache/cocoon/components/serializers/EncodingSerializer.java?r1=1764023&r2=1764022&pathrev=1764023 > XMLEncoder doesn't support Unicode surrogate pairs > -------------------------------------------------- > > Key: COCOON-2352 > URL: https://issues.apache.org/jira/browse/COCOON-2352 > Project: Cocoon > Issue Type: Bug > Components: * Cocoon Core, Blocks: Serializers > Reporter: Ben Fortuna > > Whilst investigating an issue with the Sling project and support for emoji > characters, I've come to notice that the XMLEncoder used by HTMLSerializer > doesn't support Unicode surrogate pairs to represent higher order unicode > characters. > A simple unit test that demonstrates this issue is here: > https://github.com/micronode/whistlepost/blob/master/whistlepost-rewrite-lib/src/test/groovy/org/apache/cocoon/components/serializers/encoding/XMLEncoderTest.groovy > More background info here also: SLING-5973 > This seems to have been identified/addressed in other Apache projects also: > https://issues.apache.org/jira/browse/THRIFT-3403?jql=text%20~%20%22surrogate%20pairs%22 -- This message was sent by Atlassian JIRA (v6.3.4#6332)