Findbugs is reporting an error in HexDump.java:103 on trunk:

Correctness - Bad comparison of signed byte
findbugs : INT_BAD_COMPARISON_WITH_SIGNED_BYTE
Signed bytes can only have a value in the range -128 to 127. Comparing
a signed byte with a value outside that range is vacuous and likely to
be incorrect. To convert a signed byte b to an unsigned value in the
range 0..255, use 0xff & b


On Tue, Jun 12, 2012 at 6:33 PM, Gary Gregory <ggreg...@apache.org> wrote:
> Hello All:
>
> This is a VOTE to release Commons IO 2.4-RC2.
>
> Changes since RC1:
> - Fix a bug in the new code for IO-326: Add new FileUtils.sizeOf[Directory]
> APIs to return BigInteger.
> - IO-336:  Yottabyte (YB) incorrectly defined in FileUtils. Thanks to
> rleavelle.
>
> Changes in this version include:
>
> New features:
> o IO-269:  Tailer locks file from deletion/rename on Windows. Thanks to
> sebb.
> o IO-333:  Export OSGi packages at version 1.x in addition to 2.x. Thanks
> to fmeschbe.
> o IO-320:  Add XmlStreamReader support for UTF-32. Thanks to ggregory.
> o IO-331:  BOMInputStream wrongly detects UTF-32LE_BOM files as
> UTF-16LE_BOM files in method getBOM(). Thanks to ggregory.
> o IO-327:  Add byteCountToDisplaySize(BigInteger). Thanks to ggregory.
> o IO-326:  Add new FileUtils.sizeOf[Directory] APIs to return BigInteger.
> Thanks to ggregory.
> o IO-325:  Add IOUtils.toByteArray methods to work with URL and URI. Thanks
> to raviprak.
> o IO-324:  Add missing Charset sister APIs to method that take a String
> charset name. Thanks to raviprak.
>
> Fixed Bugs:
> o IO-336:  Yottabyte (YB) incorrectly defined in FileUtils. Thanks to
> rleavelle.
> o IO-279:  Tailer erroneously considers file as new. Thanks to Sergio
> Bossa, Chris Baron.
> o IO-335:  Tailer#readLines - incorrect CR handling.
> o IO-334:  FileUtils.toURLs throws NPE for null parameter; document the
> behavior.
> o IO-332:  Improve tailer's reading performance. Thanks to liangly.
> o IO-279:  Improve Tailer performance with buffered reads (see IO-332).
> o IO-329:  FileUtils.writeLines uses unbuffered IO. Thanks to tivv.
> o IO-319:  FileUtils.sizeOfDirectory follows symbolic links. Thanks to
> raviprak.
>
>
> Compatibility with 2.3:
> Binary compatible: Yes.
> Source compatible: Yes.
> Semantic compatible: Yes.
>
> Compatibility with 2.2 and 1.4:
> Binary compatible: Yes.
> Source compatible: No, see the rare case in
> https://issues.apache.org/jira/browse/IO-318.
> Semantic compatible: No, see the rare case in
> https://issues.apache.org/jira/browse/IO-318.
>
> Commons IO 2.4 requires JDK 1.6 or later.
> Commons IO 2.3 requires JDK 1.6 or later.
> Commons IO 2.2 requires JDK 1.5 or later.
> Commons IO 1.4 requires JDK 1.3 or later.
>
> This VOTE is open for at least 72 hours until June 15 2012 at 13:00 EST.
>
> The files:
>
> https://repository.apache.org/content/repositories/orgapachecommons-231/
>
> The tag:
>
> https://svn.apache.org/repos/asf/commons/proper/io/tags/2.4-RC2
>
> The site:
>
> https://people.apache.org/builds/commons/commons-io/2.4/RC2/
>
> Thank you,
> Gary Gregory
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to