Olá Bruno, > 0) I would like to add the method Validate.notNull(...) where necessary in > [functor], if no one objects. Right now, I'm working on the following > composite functors: TransformedProcedure, TransformedFunction, > TransformedBinaryProcedure and TransformedBinaryFunction. None of these > validates the arguments, while OTOH, TransposedFunction, TransposedPredicate > and TransposedProcedure, classes in the same package, use > Validate.notNull(...).
+1 > 1) There is also unreachable code, specially in equals() methods, that checks > if an object is null before accessing its methods. But this object can never > be null, as Validate.notNull(...) or throw NPE is used to assert this in the > constructor. There is no other way to set this object. (You can still change > it through reflection, but don't think it is worth keeping it only for this > reason). I was wondering if we could remove the unreachable code, as there is > no way to write test code for it. [2] is an example of unreachable code (one > of its conditions), with the tests in [3] (there is no way to have a null > predicate). It will simplify the code, reducing decision branches and will > increase the test coverage too. sounds reasonable too, looking forward to see results! best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
