Hello Thomas, first of all: many thanks for the great effort you put into collections. I think aside from math and lang, collections is probably one of the most used components. It's really cool to see this happening. So here is my vote:
- Checksums and signatures are okay. - Site looks good, but: - PMD shows some errors that seem to be easy to fix (without having looked at the code). If I have spare time this week, I'll try to have a look. - Sources and tag have the same content - Builds fine from tag and from sources with: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100) Maven home: /Applications/dev/maven/apache-maven-3.0.5 Java version: 1.7.0_25, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.8.4", arch: "x86_64", family: "mac" One thing that could be improved is RELEASE-NOTES.txt. I think it would be good to make very clear what "alpha" means (have we agreed on this? I'm not sure). If BC breaking changes are possible but unlikely we should document this in the release notes. However no blocker. +1 Benedikt 2013/6/30 Thomas Neidhart <thomas.neidh...@gmail.com> > Hi, > > I'd like to call a vote for releasing Commons Collections 4.0-alpha1 > based on RC2. > > The following changes have been applied since RC1: > > * upgrade to maven-javadoc-plugin 2.9.1 (due to CVE-2013-1571) > * fixed COLLECTIONS-474, thanks to sebb > * fixed download page (contained wrong component id) > * added html version of release notes for site > > The artifacts / site have been built with Oracle JDK 1.5 build > 1.5.0_22-b03. > > The files: > > The artifacts are deployed to Nexus: > > https://repository.apache.org/content/repositories/orgapachecommons-092/org/apache/commons/commons-collections4/4.0-alpha1/ > > Distribution files: > https://dist.apache.org/repos/dist/dev/commons/collections/ > > The tag: > > https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_ALPHA1_RC2/ > > The site: > http://people.apache.org/builds/commons/collections/4.0-alpha1/RC2/ > > Additional Notes: > > o the download page and api links to older releases only work on > the published site and will be corrected after release. > > Please take a look at the commons-collections-4.0-alpha1 artifacts and > vote! > > ------------------------------------------------ > [ ] +1 release it. > [ ] +0 go ahead; I don't care. > [ ] -0 there are a few minor glitches: ... > [ ] -1 no, do not release it because ... > ------------------------------------------------ > > Vote will remain open for at least 72 hours. > > Thanks in advance, > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
