On 2015-01-09, <krosenv...@apache.org> wrote:
> @@ -336,20 +338,48 @@ public class ZipArchiveEntry extends jav
> * @since 1.1
> */
> public ZipExtraField[] getExtraFields(boolean includeUnparseable) {
>+ return includeUnparseable ?
>+ getAllExtraFields() :
>+ getParseableExtraFields();
>+ }
This is inconsistent WRT copying arrays or returning the internal
structure. getAllExtraFields will create a copy of extraFields (unless
there has been unparseable data), but getParseableExtraFields() does
not.
I think it would be good to always create copies here, maybe call the
no-arg version of getExtraFields instead of getParseableExtraFields?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
