Looks OK. However it might be confusing to have the same methods in both jars, so at least the class needs to be renamed.
Probably best to make the methods internal. Otherwise people might expect other related methods to be supported. This would end up with duplication of LANG methods. If it is later decided the TEXT should support more of such methods they can be made external at that point. On 18 December 2016 at 18:10, Matt Sicker <boa...@gmail.com> wrote: > That looks good to me. We do similarly in Log4j. Commons classes tend to be > written in such a way that you can copy/paste only what you need if you're > trying to prevent required dependencies. > > On 18 December 2016 at 12:06, Pascal Schumacher <pascalschumac...@gmx.net> > wrote: > >> Hello everybody, >> >> commons-text currently depends on commons-lang. This dependency is >> included into the jar via the maven shade plugin. >> >> Only two methods from lang are really needed: >> >> StringUtils#containsAny >> >> StringUtils#containsNone >> >> As dependencies should be minimized I'm not sure if adding a dependency >> for two methods (less than 60 lines of code) is a good idea. >> >> What do you think? >> >> -Pascal >> >> P.S.: I have created a pull request: https://github.com/apache/comm >> ons-text/pull/18/files to demonstrate the changes necessary for the >> removal. >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > Matt Sicker <boa...@gmail.com> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
