GitHub user tjcelaya opened a pull request:
https://github.com/apache/commons-io/pull/42
[IO-546] ClosedOutputStream#flush should throw
While debugging an issue involving usage of `CloseShieldOutputStream` I
discovered that `ClosedOutputStream#flush` is not overridden and will silently
succeed. Not sure how much of a breaking change this might be but I think it
makes more sense for `ClosedOutputStream#flush` to throw. This is only really
meaningful in contexts where multiple streams are being chained together and
some of the streams before `CloseShieldOutputStream` perform buffering, but it
would make behavior more consistent for these more complex use-cases.
See [IO-546](https://issues.apache.org/jira/browse/IO-546) where @dekobon
has attached an example program.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tjcelaya/commons-io
fix/IO-546-ClosedOutputStream-flush
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-io/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 854ed1d0d4495fa400dc4128d0e7374accb3f9c1
Author: Tomas Celaya <tjcel...@gmail.com>
Date: 2017-08-18T18:47:20Z
ClosedOutputStream#flush should throw
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
