It ended up being quite easy to get the unit test to pass, though the new functionality is no more tested than was the existing username/password functionality.
I do find in attempting to generate the site that, despite the plugin's having been set to build with Java 8, it seems that the javancss report that is configured is unable to parse :: syntax and no new release of the plugin is available. Can we remove or replace this plugin? Matt On Wed, Aug 29, 2018, 8:48 PM Rob Tompkins <chtom...@gmail.com> wrote: > > > > On Aug 29, 2018, at 7:16 PM, Matt Benson <gudnabr...@gmail.com> wrote: > > > >> On Wed, Aug 29, 2018, 5:41 PM Rob Tompkins <chtom...@gmail.com> wrote: > >> > >> > >> > >>> On Aug 29, 2018, at 4:43 PM, Matt Benson <mben...@apache.org> wrote: > >>> > >>> I have opened and resolved [1]. I classified this as a bug. Should we > >>> consider a 1.4.1 release or just leave the master version at > >> 1.5-SNAPSHOT? > >> > >> I can do either. Seems like a good move before [parent] v48. Thoughts? > >> > > > > +1. I'm also working on a change to consult a server definition from > Maven > > settings, as with the maven-scm-publish plugin. I believe my code is > > correct; however I am still working on the tests since they now expect > the > > settings object to have been injected. > > > > Sweet. > > > Matt > > > >> > >> -Rob > >> > >>> It appears I can do the weaver release using a locally overridden > >> snapshot > >>> build of the plugin, so I don't think I'm blocked (or worse, forced to > do > >>> things manually :P). > >>> > >>> Matt > >>> > >>> [1] https://issues.apache.org/jira/browse/COMMONSSITE-122 > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
