Missed the vote (holiday in Auckland), but my late +1, and thanks for RM'ing
it Gary!
Bruno
On Monday, 28 January 2019, 10:32:53 AM NZDT, Gary Gregory
<garydgreg...@gmail.com> wrote:
May I get at least one more review please?
Gary
On Sun, Jan 27, 2019, 10:07 Rob Tompkins <chtom...@apache.org wrote:
> +1
> signatures good, sha1 (nexus), md5 (nexus), sha512, asc
>
> builds in java8 and java11
>
> Issue: RELEASE-NOTES.txt has 6.3-SNAPSHOT not 6.3 in it (Fixable)
>
> Nits:
> checkstyle, pmd, cpd, findbugs few issues.
>
> ———————————
> Aside: I will try to get to the collections-4.3 [VOTE] before the end of
> the day
>
>
> > On Jan 24, 2019, at 4:19 PM, Gary Gregory <ggreg...@apache.org> wrote:
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons BCEL 6.2 was released, so I would like to release
> > Apache Commons BCEL 6.3.
> >
> > Apache Commons BCEL 6.3 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1 (svn
> > revision 32125)
> >
> > The Subversion tag for this RC is here:
> >
> https://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_3_RC1/
> > (svn revision 1852073)
> > N.B. the SVN revision is required because SVN tags are not immutable.
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1410/org/apache/bcel/bcel/6.3/
> >
> > These are the Maven artifacts and their hashes in Nexus:
> >
> > ${commons.sha256list}
> > #Release SHA-512s
> > #Thu Jan 24 15:38:52 EST 2019
> >
> bcel-6.3-javadoc-javadoc=91dd316818395e937cd86584d1fc55bf2e392a5b08225aab691c8e34821d56fbcd0c31036dcea00f7b4ce78429e2f69443c396f946eee571cb012ca023f2bec7
> >
> bcel-6.3-src-tar.gz.asc=04bbed23cc3f64401d6495ecb8e08d068dc9a28d06b3f2965b1d190c550db97683949d5a64a1050d7cecb24fd6b650080b0dcdfe45849c52fb98b39ed651ba5d
> >
> bcel-6.3-src-zip.asc=458ee35da2f2d7cec7c7ec9745fbcec4f3c5db366691779fa6ae5ca950b622a73689f373719e5756f89a46d2de82c57187a62e7b8722d100a641aae76623f14f
> >
> bcel-6.3-bin-zip.asc=75ff4a83785d4134b6f516d2adcc9d3678fa18d8f209c1f302d089b0a977f937339cf387e6b742b716963855eaa347473f1b96e19c288a70060939d18f542189
> >
> bcel-6.3-src-tar.gz=358377437a2f667484deca3cf2f3f189ceaaf830dd8a04586047d1a057cd1f3cacc7cb6beaab363c2c7914608b4566cba355790c7b031e5502cd71d5047cb102
> >
> bcel-6.3-tests-test-jar=c5176022291e622b55ad2f2b656c14169d8c7dcf7c19548322da544fc65440032d5a04805032bbf084feaf17ce81807cd91c3b9fabecb345776051892a47a64c
> >
> bcel-6.3-tests-jar.asc=533006b11a6bd196d29d8edf1e89e718ed06be922b80ea93a624295851a818ebef0a1f83ed36efaf66cde98cd2201a93e707dfb468666f6ee1b2d0938d4e29be
> >
> bcel-6.3-bin-zip=664f7d6b55f00b0f3a7bc8851da8f82dba4c077c32fdc1933dedad9662f5c9daf083d9e92e703fb6b89cd3f9c998fdf64fd3cba70f5d30bbc703af2dd8856734
> >
> bcel-6.3-sources-jar.asc=c912eeff39eee81a3b8cdb3c610aefa4ede08719688996b93c618571056daa70f4f7b4730177d320ddd257bb855f83452d218077d9d806700df164f1bc90dd89
> >
> bcel-6.3-bin-tar.gz=6461c1dfa27ead22ba7463ff2fbc1b385fbb46c48465cb4bb4a158a98f6fce3396efd48222e523862e5a7af3993ee777013498e05c5ff4125b8aa02317d434c2
> >
> bcel-6.3-test-sources-jar.asc=323f43172b68f96c47f101a3f510f93170d5ca7d5c49b8e0d4dd8926e79818a8caf86697f31d24c4589d1204816a90454aba68f49a90017f47ecb50651f1d1c4
> >
> bcel-6.3-test-sources-java-source=7879894ea7e9b5cd0318de41b1fd45511787935588a04a95ebcf04adccdf60bd981744919698379ea15fc7bc2398e7605a5766e70e1affa9af47959dabf3e121
> >
> bcel-6.3-pom.asc=25a7f4b9371130e85436831f122ccf2ebf8e98f9440060c0e7efe884346565dc563c7fccd91b9b24bfad0c8a359ec1ecc541edaaa3dac111578bcf4005782ff2
> >
> bcel-6.3-javadoc-jar.asc=32c951bf4347858b9b4d863118e9a3753584519eee89ff035cbb883a010d8333eca2d8c18aacf21bebbcb949999ebf66e8dbab873ee7242fb5d2bc7a1a0d24da
> >
> bcel-6.3-jar.asc=dc43ed9c2c2d2cb10fd9a2af9053120018a96bc68422905dc7e0426082bf60396d9bb646fb879801a0b2c7d98aea5cfe8579b27b684f78608b3348ea807ccc79
> >
> bcel-6.3-sources-java-source=b8b5d2590334730582c9dd93e28d4636fda9ac47ad34816d7ab8e4a771ac61e1b20b8c14208409d0652c6f8a2b63c4155295ddbee56e21273792267f9c7357ff
> >
> bcel-6.3-bin-tar.gz.asc=2e4d8283567f5518270da83d9b0176da4325671d855bf05073bdf5c6feaa4e43653c49cad0aec0dbcc4e01b5605bf47c5508531dce4a70f61f5e8c81c6cffe97
> >
> bcel-6.3-src-zip=18a4caa594b37e8aae3c5a095260f9d3b04df5bcbfdcbe8a43feb15a7a4d2b9ea834331bd93ca8d461e7f791c390262fbca788bb4ee70d7bde4e7f85ea34bdee
> >
> > (no need for .asc hashes!)
> >
> > I have tested this with 'mvn -Ddoclint=none clean package site' using:
> >
> > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> > 2018-10-24T14:41:47-04:00)
> > Maven home: C:\Java\apache-maven-3.6.0\bin\..
> > Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_202\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Details of changes since 6.2 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/RELEASE-NOTES.txt
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/site/changes-report.html
> >
> > Site:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/site
> > (note some *relative* links are broken and the 6.3 directories are not
> > yet created - these will be OK once the site is deployed.)
> >
> > CLIRR Report (compared to 6.2):
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/site/clirr-report.html
> >
> > Note that Clirr reports one errors:
> > Method 'public void
> > visitConstantDynamic(org.apache.bcel.classfile.ConstantDynamic)' has been
> > added to an interface
> > This acceptable because Clirr does not know how to deal with Java 8
> > default methods.
> >
> >
> > JApiCmp Report (compared to 6.2):
> > This report was not run and is empty.
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/site/japicmp.html
> >
> > RAT Report:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.3-RC1/site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
