Hi Alex. Le ven. 10 mai 2019 à 13:57, Alex Herbert <alex.d.herb...@gmail.com> a écrit : > > Can I get a review of the PR for RNG-101 please.
Thanks for this work! I didn't go into the details; however, I see many fields and methods like table1 ... table5 fillTable1 ... fillTable5 getTable1 ... getTable5 Wouldn't it be possible to use a 2D table: table[5][]; so that e.g. only one "fillTable(int tableIndex, /* other args */)" method is necessary (where "tableIndex" runs from 0 to 4)? The diff for "DiscreteSamplersList.java" refers to MarsagliaTsangWangBinomialSampler but MarsagliaTsangWangSmallMeanPoissonSampler seems to be missing. Regards, Gilles > This is a new sampler based on the source code from the paper: > > George Marsaglia, Wai Wan Tsang, Jingbo Wang (2004) > Fast Generation of Discrete Random Variables. > Journal of Statistical Software. Vol. 11, Issue. 3, pp. 1-11. > > https://www.jstatsoft.org/article/view/v011i03 > > The code has no explicit licence. > > The paper states: > > "We have provided C versions of the two methods described here, for > inclusion in the “Browse > files”section of the journal. ... You may then want to examine the > components of the two files, for illumination > or for extracting portions that might be usefully applied to your > discrete distributions." > > So I assuming that it can be incorporated with little modification. > > The Java implementation has been rewritten to allow the storage to be > optimised for the required size. The generation of the tables has been > adapted appropriately and checks have been added on the input parameters > to ensure the sampler does not generate exceptions once constructed (I > found out the hard way that the original code was not entirely correct). > > Thanks. > > Alex --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
