Hi Matt, Inspected NOTICE, LICENSE, RELEASE-NOTES, and found no issues. Checked out the tag, and `mvn clean test install site` passed with no errors.
The README is still showing 2.7 in the download instructions. I **think** one of the preparation steps uses a release-plugin goal that re-generates this file with the correct version, but I could be wrong. Not sure if it's a blocker? Another thing that I noticed, but probably just nit-picking; opening a zip and a tar.gz file from dist/source folders each, and opening each file on Ubuntu LTS, I think not all files are UTF-8 encoded. The RELEASE-NOTES.txt fails to open on my Mousepad editor. It pops up an error dialogue that lets me try to guess the encoding to open it. Not an issue for me as I think it happens in other projects (I think CSV had a non-utf readme or release note too). Site reports look great. Tested signatures from Maven and from dist area, found no issues. [x] +1 Release these artifacts (if the README issue is not a blocker) Thanks! -Bruno On Tue, 21 Jun 2022 at 16:34, Matt Juntunen <matt.a.juntu...@gmail.com> wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Configuration 2.7 was released, so I would like > to release Apache Commons Configuration 2.8. > > Apache Commons Configuration 2.8 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC1 > (svn revision 55235) > > The Git tag commons-configuration-2.8-RC1 commit for this RC is > 01e1b40769f6dd5046c74f38c4c59cf4af5e37a1 which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-configuration.git;a=commit;h=01e1b40769f6dd5046c74f38c4c59cf4af5e37a1 > You may checkout this tag using: > git clone > https://gitbox.apache.org/repos/asf/commons-configuration.git > --branch > <https://gitbox.apache.org/repos/asf/commons-configuration.git--branch> > commons-configuration-2.8-RC1 commons-configuration-2.8-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1589/org/apache/commons/commons-configuration2/2.8/ > > These are the artifacts and their hashes: > > > commons-configuration2-2.8.jar=c54782ba1d6340ccf0e136c66281af7bfcf3a78235f4a2461b50a88351a6da4f463cb19ca49afb25ff82712c4f4f14985c9f960ea65213deb1ca5a9719dead38 > > commons-configuration2-2.8-sources.jar=1e277840f25d6a89b8f9168b5dd174093db38807b13e080aa47d26ff35602e4f5e4d6cf8bece6780af6791befd2204ce25710a8cd8eea62eabe3b554ea96e28c > > commons-configuration2-2.8-tests.jar=e0ffd6379863426f8b3237dd3ee64f7345c8d2876a34b736ba5f653af1e7cd99a8a3825938c60f842599f0a43922bbb32d13ea7f0c624b8dce25edf0150c6496 > > commons-configuration2-2.8-test-sources.jar=f8c88936f415ab8357c96a73f9cb318e805b6a2ae47a9de9b3176c68b1fc1f4ca8880baf9045381a29af3d858be1c3b38b9f7f9bafd700f648004b591327dc1d > > commons-configuration2-2.8-bin.tar.gz=061227c898cf9094e30feebcf71d2811eecb01951793f30a6afca4f11075e5789231956b3d92b2caa5d65a24aa835026527b7d8b7dc81b1743306a48cae67ce4 > > commons-configuration2-2.8-bin.zip=47a05cf9bcfee4e5f96f7d23af463bbf56e3d044ba1ea5faaeddb34f7056ca6590e15c83738a79a46c5d5d22885d5bac7dd3930a69d21b6a05c6645f0bcc383e > > commons-configuration2-2.8-src.tar.gz=eed2b99ebba4320799f8a11fde59c180022fd93f4c7b2c597398929368c92cce6828b163976c47629a0edf8fbc0e86be5cdf3e5f01cc734dd08f716038df026f > > commons-configuration2-2.8-src.zip=321365d65479889d16e27db4e03c52cfd8a4241b0a6ef2fe1f39d07f5beed4d5d9fb09d4101de77769ef634b2f9bda46a9ba4baa706540de42605c8c1e401c8f > > I have tested this with 'mvn clean install site' using: > *** > Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) > Maven home: /home/matt/tools/maven/apache-maven-3.8.4 > Java version: 1.8.0_322, vendor: Temurin, runtime: > /home/matt/lang/java/jdk8u322-b06/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "5.17.12-300.fc36.x86_64", arch: "amd64", > family: "unix" > *** > > Details of changes since 2.7 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/configuration/2.8-RC1/RELEASE-NOTES.txt > > https://home.apache.org/~mattjuntunen/commons-configuration-2.8-rc1-site/changes-report.html > > Site: > > https://home.apache.org/~mattjuntunen/commons-configuration-2.8-rc1-site/index.html > (note some *relative* links are broken and the 2.8 directories are > not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 2.7): > > https://home.apache.org/~mattjuntunen/commons-configuration-2.8-rc1-site/japicmp.html > > RAT Report: > > https://home.apache.org/~mattjuntunen/commons-configuration-2.8-rc1-site/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Matt Juntunen, > Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > ============================== > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1) Clone and checkout the RC tag > > git clone https://gitbox.apache.org/repos/asf/commons-configuration.git > --branch > <https://gitbox.apache.org/repos/asf/commons-configuration.git--branch> > commons-configuration-2.8-RC1 commons-configuration-2.8-RC1 > cd commons-configuration-2.8-RC1 > > 2) Check Apache licenses > > This step is not required if the site includes a RAT report page which > you then must check. > > mvn apache-rat:check > > 3) Check binary compatibility > > Older components still use Apache Clirr: > > This step is not required if the site includes a Clirr report page > which you then must check. > > mvn clirr:check > > Newer components use JApiCmp with the japicmp Maven Profile: > > This step is not required if the site includes a JApiCmp report page > which you then must check. > > mvn install -DskipTests -P japicmp japicmp:cmp > > 4) Build the package > > mvn -V clean package > > You can record the Maven and Java version produced by -V in your VOTE > reply. > To gather OS information from a command line: > Windows: ver > Linux: uname -a > > 5) Build the site for a single module project > > Note: Some plugins require the components to be installed instead of > packaged. > > mvn site > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > 6) Build the site for a multi-module project > > mvn site > mvn site:stage > Check the site reports in: > - Windows: target\site\index.html > - Linux: target/site/index.html > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
