Great work, thank you for this Nick!

What about hose candidates too?

        b64url, 
        ets_lru 
        khash


Original discussion at Slack (because of the 90 days limit of slack,
I will post the part of the discussion):

vatamane  
  21:51 Uhr     Noticed it was kind of a pain to manage the separate config app 
and wondering it's it's worth keeping at a separate repo
  21:51 Uhr     Sent a question to the mailing list about it
  21:52 Uhr     Waiting on travis CI to pick up the job and start running it 
kind of was the trigger for it
  21:52 Uhr     that and the extra tag + extra PR, all for a minor change in 
the code...


big-r  
  22:15 Uhr     Can this discussion be extended to other "external" couchdb-* 
repositories?
  22:17 Uhr     What was the main reason to separate them and are they used by 
external apps?


jaydoane
  23:09 Uhr     you mean these?
                        DepDescs = [
                                %% Independent Apps
                                {config,           "config",           {tag, 
"2.2.0"}},
                                {b64url,           "b64url",           {tag, 
"1.0.3"}},
                                {ets_lru,          "ets-lru",          {tag, 
"1.1.0"}},
                                {khash,            "khash",            {tag, 
"1.1.0"}},
                                {snappy,           "snappy",           {tag, 
"CouchDB-1.0.8"}},

                                %% %% Non-Erlang deps
                                {fauxton,          {url, 
"https://github.com/apache/couchdb-fauxton"},
                                {tag, "v1.2.8"}, [raw]},
                                
                                %% Third party deps
                                {folsom,           "folsom",           {tag, 
"CouchDB-0.8.4"}},
                                {hyper,            "hyper",            {tag, 
"CouchDB-2.2.0-7"}},
                                {ibrowse,          "ibrowse",          {tag, 
"CouchDB-4.4.2-5"}},
                                {jiffy,            "jiffy",            {tag, 
"1.1.1"}},
                                {mochiweb,         "mochiweb",         {tag, 
"v3.1.0"}},
                                {meck,             "meck",             {tag, 
"0.9.2"}},
                                {recon,            "recon",            {tag, 
"2.5.2"}}
                        ].

big-r
  23:27 Uhr     Yes, the first part…

jaydoane
  23:30 Uhr     I suspect in general they were left separate after the Great 
Unification because they could be used independently of CouchDB, 
                        but the headaches caused by keeping them separate may 
not be worth it, as Nick pointed out

vatamane
  23:54 Uhr     khash and b64url could potentially be used externally, they are 
less tied to CouchDB
  23:55 Uhr     khash though could probably be replaced with maps these days
  23:56 Uhr     ets_lru is a single .erl file
  23:57 Uhr     that could be in couch_util or something
  23:59 Uhr.            @big-r yeah good idea, I can see ets_lru, khash and 
b64url as good candidates


vatamane
  00:01 Uhr     b64url is also being replaced by the otp base64 url + an 
urlsafe alphabet too, there is a good chance users would just pick that
                        
https://github.com/erlang/otp/commit/05e61dc7eb568cc5a5db965dcc3534fb6c9aa66d 
eventually 
                        (not that I know if anyone our b64url anyway) 
(bearbeitet) 

rnewson
  10:13 Uhr     it's partly that they can be used without couchdb but also an 
attempt to preserve that decoupling. we've been back and forth on it. 
                        It seems pretty clear that no one is interested in 
using those components separately so I'm onboard with folding them back into 
the main repo


/Ronny

> Am 26.10.2022 um 17:39 schrieb Nick Vatamaniuc <vatam...@gmail.com>:
> 
> Thanks for the feedback, everyone.
> 
> config application has now been integrated into main in
> https://github.com/apache/couchdb/pull/4242
> 
> 
> On Tue, Oct 4, 2022 at 3:23 AM Jan Lehnardt <j...@apache.org> wrote:
>> 
>> No objections.
>> 
>> Best
>> Jan
>> 
>> —
>> Professional Support for Apache CouchDB:
>> https://neighbourhood.ie/couchdb-support/
>> 
>> 24/7 Observation for your CouchDB Instances:
>> https://opservatory.app
>> 
>>> On 28. Sep 2022, at 21:32, Nick Vatamaniuc <vatam...@apache.org> wrote:
>>> 
>>> Hi everyone,
>>> 
>>> What do we think about integrating couchdb-config into the main couchdb 
>>> repo?
>>> 
>>> Currently it's a separate repo, with a different CI (Travis), which
>>> takes quite a bit of time waiting to schedule runs, has a different
>>> configuration file etc. Any updates to config needs a new tag and a
>>> corresponding bump and a separate PR in the main repo.
>>> 
>>> Over the years it has been intermingled with couch_log and other
>>> CouchDB bits and that wouldn't make it as appealing to use as a
>>> separate application, so let's at least make life easier for us? What
>>> does everyone think?
>>> 
>>> Thanks,
>>> -Nick
>> 

Reply via email to