bdemers commented on issue #564: URL: https://github.com/apache/directory-scimple/issues/564#issuecomment-2066807533
Hi @joshuapsteele! I only had a minute to poke around at this, but my guess is it's related to the ANTLR grammar, the def for `STRING` looks like it's only parsing ASCII, and would need to be improved. It looks like there is a better/improved grammar here: https://github.com/antlr/grammars-v4/blob/master/json/JSON.g4 Which contains: ```txt STRING : '"' (ESC | SAFECODEPOINT)* '"' ; fragment ESC : '\\' (["\\/bfnrt] | UNICODE) ; fragment UNICODE : 'u' HEX HEX HEX HEX ; fragment HEX : [0-9a-fA-F] ; fragment SAFECODEPOINT : ~ ["\\\u0000-\u001F] ; ``` I did a quick replacement in `src/main/antlr4/imports/Json.g4` and it seemed to fix the parsing error, but test failed still because of an equality check of a filter with `B\u00EDlbo` and `Bílbo`. (my guess is test needs to be tweaked a bit 🤷, but I don't have time to dig into it more today) Anyway, great find, hopefully the above info helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
