chenhao7253886 commented on a change in pull request #832: Support hll_raw_agg
in Aggregate Function
URL: https://github.com/apache/incubator-doris/pull/832#discussion_r270705946
##########
File path: be/src/udf/udf.h
##########
@@ -762,6 +766,45 @@ struct LargeIntVal : public AnyVal {
}
};
+struct HllVal : public StringVal {
+
Review comment:
I think HllFullVal is a better name, because your HllVal only represent the
Full type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
