chaoyli commented on a change in pull request #872: Rename rowset id in restore
stage
URL: https://github.com/apache/incubator-doris/pull/872#discussion_r272047286
##########
File path: be/src/olap/tablet_meta.cpp
##########
@@ -355,12 +355,15 @@ OLAPStatus TabletMeta::add_rs_meta(const
RowsetMetaSharedPtr& rs_meta) {
return OLAP_SUCCESS;
}
-OLAPStatus TabletMeta::delete_rs_meta_by_version(const Version& version) {
+OLAPStatus TabletMeta::delete_rs_meta_by_version(const Version& version,
vector<RowsetMetaSharedPtr>* deleted_rs_metas) {
auto it = _rs_metas.begin();
while (it != _rs_metas.end()) {
if ((*it)->version().first == version.first
&& (*it)->version().second == version.second) {
_rs_metas.erase(it);
+ if (deleted_rs_metas != nullptr) {
Review comment:
It has be deconstructed after erasure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
