imay commented on a change in pull request #881: Add unit test for
RoutineLoadManager and RoutineLoadJob
URL: https://github.com/apache/incubator-doris/pull/881#discussion_r272586630
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -682,21 +668,27 @@ public ListenResult onAborted(TransactionState txnState,
String txnStatusChangeR
}
// todo(ml): use previous be id depend on change reason
} else {
- LOG.debug(new LogBuilder(LogKey.ROUINTE_LOAD_TASK,
txnState.getLabel()).add("txn_id",
- txnState.getTransactionId()).add("msg", "txn
abort").build());
+ LOG.debug(new LogBuilder(LogKey.ROUINTE_LOAD_TASK,
txnState.getLabel())
+ .add("txn_id",
txnState.getTransactionId()).add("msg", "txn abort").build());
}
// step2: commit task , update progress, maybe create a new
task
executeCommitTask(routineLoadTaskInfo, txnState);
++abortedTaskNum;
result = ListenResult.CHANGED;
+ } else {
+ LOG.debug(new LogBuilder(LogKey.ROUTINE_LOAD_JOB, id)
Review comment:
```suggestion
if (LOG.isDebugEnabled()) {
LOG.debug(new LogBuilder(LogKey.ROUTINE_LOAD_JOB, id)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
