+1 for this proposal.

Not every data team would like to enable hints. Also because they are an extension to the SQL standard. It might also be the case that custom rules would be overwritten otherwise. Setting hints could also be the exclusive task of a DevOp team.

Regards,
Timo


On 17.08.23 09:30, Konstantin Knauf wrote:
Hi Bonnie,

this makes sense to me, in particular, given that we already have this
toggle for a different type of hints.

Best,

Konstantin

Am Mi., 16. Aug. 2023 um 19:38 Uhr schrieb Bonnie Arogyam Varghese
<bvargh...@confluent.io.invalid>:

Hi Liu,
  Options hints could be a security concern since users can override
settings. However, query hints specifically could affect performance.
Since we have a config to disable Options hint, I'm suggesting we also have
a config to disable Query hints.

On Wed, Aug 16, 2023 at 9:41 AM liu ron <ron9....@gmail.com> wrote:

Hi,

Thanks for driving this proposal.

Can you explain why you would need to disable query hints because of
security issues? I don't really understand why query hints affects
security.

Best,
Ron

Bonnie Arogyam Varghese <bvargh...@confluent.io.invalid> 于2023年8月16日周三
23:59写道:

Platform providers may want to disable hints completely for security
reasons.

Currently, there is a configuration to disable OPTIONS hint -



https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/#table-dynamic-table-options-enabled

However, there is no configuration available to disable QUERY hints -



https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/dev/table/sql/queries/hints/#query-hints

The proposal is to add a new configuration:

Name: table.query-options.enabled
Description: Enable or disable the QUERY hint, if disabled, an
exception would be thrown if any QUERY hints are specified
Note: The default value will be set to true.






Reply via email to