[ 
http://issues.apache.org/jira/browse/GERONIMO-2324?page=comments#action_12428525
 ] 
            
David Jencks commented on GERONIMO-2324:
----------------------------------------

To clarify my earlier points, in order

-  It is certainly possible to get support for exploded jars by adding more 
entries to the classes attribute.  If each jars were to be all by itself in a 
directory it would be possible to add an entry to libs for each jar.  I think 
that the runtime refresh characteristics of both solutions would be the same.  
I'm not convinced dragging xml into this class is worth it for the minimal 
gains in functionality, namely not pulling in all the jars in a directory in 
which you only have one jar you want.

- IMO the shared lib is a bad idea that is included only for those who are not 
willing to explicitly specify their dependencies.  Adding extra-fancy features 
to it doesn't make it a better idea.  I think we should be encouraging people 
to use the geronimo/maven repo.  A corresponding feature for the repo would be 
some metadata in the repo that says, "actually the artifact is over here, 
unpacked"  I'd rather see that feature than this one.

- I think writing out the externals file will fail in a lot of scenarios.

- tests are still good

In addition:

- I think that exactly the same effect can be obtained with no code change by 
putting a jar in shared/lib with a manifest classpath that points to the 
locations of interest

- I would also much rather see a solution that does not require restarting the 
shared lib config in order to pick up changes.  (I'm not actually sure about 
the behavior of shared lib -- maybe someone who knows can clarify)

> Allow in-place and exploded jar support for sharedlib
> -----------------------------------------------------
>
>                 Key: GERONIMO-2324
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2324
>             Project: Geronimo
>          Issue Type: RTC
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 1.1
>            Reporter: Sachin Patel
>         Assigned To: Sachin Patel
>             Fix For: 1.x
>
>         Attachments: GERONIMO-2324.patch, GERONIMO-2324.patch
>
>
> The shared library support should allow in-place support to allow and load 
> jars (exploded as well) that are located externally on the filesystem.  This 
> is needed to improve developer experience and allow better integration within 
> tooling and the runtime.
> Perhaps we can have a properties file insie the shared lib that have external 
> entries in them.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to