[ https://issues.apache.org/activemq/browse/SM-780?page=all ]

Guillaume Nodet resolved SM-780.
--------------------------------

    Resolution: Fixed

Sorry about that. Thanks for reporting and providing a patch :)

Author: gnodet
Date: Fri Dec 15 06:58:00 2006
New Revision: 487576

URL: http://svn.apache.org/viewvc?view=rev&rev=487576
Log:
SM-780: Bug due to change in proxy support for http binding component
Thanks to Martin Landua for this patch !

Modified:
   
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java


> Bug due to change in proxy support for http binding component
> -------------------------------------------------------------
>
>                 Key: SM-780
>                 URL: https://issues.apache.org/activemq/browse/SM-780
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-http
>    Affects Versions: 3.1
>         Environment: All
>            Reporter: Martin Landua
>             Fix For: 3.1
>
>
> The class ProviderProcessor supports proxies now. However, there is a 
> NullPointer Exception, when no proxy is configured. Please verify the 
> attached diff.
> Best regards.
> Martin
> Index: 
> D:/JBossIDE/ServiceMix/ServiceMix-SNAPSHOT/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java
> ===================================================================
> --- 
> D:/JBossIDE/ServiceMix/ServiceMix-SNAPSHOT/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java
>        (revision 487484)
> +++ 
> D:/JBossIDE/ServiceMix/ServiceMix-SNAPSHOT/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java
>        (working copy)
> @@ -260,12 +260,12 @@
>              if ((endpoint.getProxy().getProxyHost() != null) && 
> (endpoint.getProxy().getProxyPort() != 0)) {
>                  host.setProxy(endpoint.getProxy().getProxyHost(), 
> endpoint.getProxy().getProxyPort());
>              }
> +            if (endpoint.getProxy().getProxyCredentials() != null) {
> +                
> endpoint.getProxy().getProxyCredentials().applyProxyCredentials(getClient());
> +            }
>          } else if ((getConfiguration().getProxyHost() != null) && 
> (getConfiguration().getProxyPort() != 0)) {
>              host.setProxy(getConfiguration().getProxyHost(), 
> getConfiguration().getProxyPort());
>          }
> -        if (endpoint.getProxy().getProxyCredentials() != null) {
> -            
> endpoint.getProxy().getProxyCredentials().applyProxyCredentials(getClient());
> -        }
>          return host;
>      }
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to