Aaron,

Can you look at the comments I posted to the JIRA and check if we can
conclude the "hunt"?

Thanks,
Vamsi

On 1/2/07, Vamsavardhana Reddy (JIRA) <[EMAIL PROTECTED]> wrote:


    [
http://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461709]

Vamsavardhana Reddy commented on GERONIMO-438:
----------------------------------------------

To make sure that  PackageBuilder.invokeDeployer() is the only place
outside Deployer where the 3rd method is used, I have introduced
(temporarily) an extra string argument in the method signature and built the
server.  There were no build errors and the server ran fine.  I hope this
info will also be helpful.

> Deployer.deploy arguments inconsistent
> --------------------------------------
>
>                 Key: GERONIMO-438
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-438
>             Project: Geronimo
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 1.0-M2
>            Reporter: Aaron Mulder
>             Fix For: Wish List
>
>         Attachments: g-438-11x-option2.patch, g-438-option1.patch,
g-438-option2.patch
>
>
> One deploy method starts with the arguments:
>   File module, File plan
> Another overloaded deploy method starts with the arguments:
>   File plan, File module
> These should not be reversed, but we need to carefully hunt down usages
since the types alone won't cause the usages to be flagged if one is
switched.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Reply via email to