[
https://issues.apache.org/activemq/browse/AMQCPP-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_37864
]
Albert Strasheim commented on AMQCPP-40:
----------------------------------------
Which standard specifies "unix" or "__unix__" as something that is defined on
all UNIX systems? I'd like to read up on this. Thanks!
> A few stray unix and sun defines
> --------------------------------
>
> Key: AMQCPP-40
> URL: https://issues.apache.org/activemq/browse/AMQCPP-40
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Albert Strasheim
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 2.0
>
>
> The AMQCPP code still contains a few references to the unix and sun defines.
> {noformat}
> ./src/main/activemq/concurrent/Mutex.h:#if (defined(__unix__) ||
> defined(unix) || defined(MACOSX)) && !defined(USG)
> ./src/main/activemq/concurrent/Thread.h:#if (defined(__unix__) ||
> defined(unix) || defined(MACOSX) || defined(__APPLE__)) && !defined(USG)
> ./src/main/activemq/util/Guid.h: #if defined( unix ) ||
> defined(__APPLE__)
> ./src/main/activemq/util/Config.h: // used by unix like systems
> (including cygwin)
> ./src/main/activemq/util/Config.h: #elif defined( unix )
> ./src/main/activemq/util/Endian.h:#if defined( unix ) || defined(__APPLE__)
> ./src/main/activemq/util/Endian.h:# if defined( unix ) || defined(__APPLE__)
> ./src/main/activemq/network/ServerSocket.h: #if !defined( unix ) ||
> defined( __CYGWIN__ )
> ./src/main/activemq/network/SocketOutputStream.cpp:#elif defined( unix ) &&
> !defined( __CYGWIN__ ) && !defined( sun )
> {noformat}
> These should probably be replaced by some kind of AMQ_ variant. It would nice
> if one could define a single AMQ_something per platform, akin to Windows's
> _WIN32 define.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
