[ 
https://issues.apache.org/jira/browse/GERONIMO-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463822
 ] 

Rakesh Midha commented on GERONIMO-2689:
----------------------------------------


Thanks Kevan, for spending time and integrating this patch.

1) About finalize(), I didnt notice that I used upper case 'F', you are right 
it should be lower case "finalize" . Now about using destroy()/finalize(). I 
used all three technicques finalize(), destroy() and weak references to remove 
ClassLoaders from registry, not just because I am worried about circular 
reference, but also because I don't want to depend too much on weak references 
or finalize() implementation in GC and destroy() calling from Geronimo code. I 
want to leave no chance hence used all the precautions I could. (In no case I 
want Classloadere to be not GC'd because of its refernce in Registry). I hope 
this convince you for using combination of destroy()/finalize() and weak 
references.

2) You are right, I spent some time on this code and didnt took the latest from 
SVN before making patch, my mistake, do you want me to do that for me. 

I promise I will take care of this from next patch onways, forgive this time.

Christopher, I could not figure out what dojo widgets names you changed. Can 
you list them please.

Thanks

> New View for JNDI name in all the contexts
> ------------------------------------------
>
>                 Key: GERONIMO-2689
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2689
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.0
>         Environment: Any
>            Reporter: Rakesh Midha
>         Assigned To: Kevan Miller
>             Fix For: 2.0
>
>         Attachments: allviews.patch, common.patch, G2689-2690-2691.patch, 
> jndi.gif, jndiview2689.patch, navigation.gif
>
>
> So many times we hit the Exception NamingNotFound, most of the times it 
> happens because of user error, missing references, wrong names or path or 
> user working in different context and system looking in some other context.
> I think it would be nice if in a console we can have a view of what all names 
> are binded or available in contexts of each application / module or component.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to