How does that fix it?
BTW, no modules should depend on testsupport-common in their pom.xml,
as its already defined in modules/pom.xml. Looks like web-2.5-
builder is not using the test scope either.
Probably need to do a quick scan to see who else is adding this dep
explicitly and remove it.
But... I still don't see who this will fix the missing JCL in
geronimo-jetty6-builder, but just woke up maybe it be clearer in a
few hours.
--jason
On Jan 13, 2007, at 4:45 AM, anita kulshreshtha wrote:
The same effect can be achieved by removing dependency on
testsupport-common in web-2.5-builder. This allows JCL to be picked
from g-kernel transitively in jetty6-builder. I like this solution
better.
Thanks
Anita
--- [EMAIL PROTECTED] wrote:
Author: jdillon
Date: Sat Jan 13 01:22:30 2007
New Revision: 495857
URL: http://svn.apache.org/viewvc?view=rev&rev=495857
Log:
Add commons-logging to get around strange maven exclusion thingy,
should not need to define this dep it should be picked up
transitively
Modified:
geronimo/server/trunk/modules/geronimo-jetty6-builder/pom.xml
Modified:
geronimo/server/trunk/modules/geronimo-jetty6-builder/pom.xml
URL:
http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-
jetty6-builder/pom.xml?view=diff&rev=495857&r1=495856&r2=495857
======================================================================
========
--- geronimo/server/trunk/modules/geronimo-jetty6-builder/pom.xml
(original)
+++ geronimo/server/trunk/modules/geronimo-jetty6-builder/pom.xml Sat
Jan 13 01:22:30 2007
@@ -33,7 +33,6 @@
<name>Geronimo :: Jetty 6 :: Builder</name>
<dependencies>
-
<dependency>
<groupId>${pom.groupId}</groupId>
<artifactId>geronimo-web-2.5-builder</artifactId>
@@ -46,6 +45,17 @@
<version>${version}</version>
</dependency>
+ <!--
+ NOTE: This should have been picked up from geronimo-kernel
(or geronimo-util)
+ but I think this might be caused by a bug in Maven,
its overzelously
+ excluding dependencies. Might be fixed in Maven
2.0.5, check again
+ when its been released.
+ -->
+
+ <dependency>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </dependency>
</dependencies>
<build>
______________________________________________________________________
______________
Any questions? Get answers on any topic at www.Answers.yahoo.com.
Try it now.
