On 3/9/07, bradtwurst <[EMAIL PROTECTED]> wrote:
Guillaume Nodet commented on SM-275:
------------------------------------
Wow, thanks a lot !
I think the code could be reduced a lot.
* the bootstrap can be removed (it seems to do nothing interesting)
* the endpoint can be simplied too as lots of methods are already
defined on the parent class (getRole, activate, deactivate,
getProcessor,
send, done, fail, etc ...)
I think the only needed methods are: start, stop and processInOut
If you could use spaces and not tabs, it would be awesome :-)
I will take a deeper look next week.
------------------------------------------------------
No problem, I was using the code generated from the generic maven
archetype
for the service unit.
I guess it should be updated then ...
I will remove the bootstrap and take another look at the endpoint. (this is
my first attempt at creating a service unit :) )
I was using the default eclipse formatting (according to an earlier
thread,
that was the desired configuration)
Anyway, I will change it to be spaces instead of tabs
Sorry about that ;-)
James
--
View this message in context:
http://www.nabble.com/Commented%3A-%28SM-275%29-Consider-enhancing-file-based-components-with-servingxml-tf3377065s12049.html#a9400954
Sent from the ServiceMix - Dev mailing list archive at Nabble.com.
--
Cheers,
Guillaume Nodet
------------------------
Architect, LogicBlaze (http://www.logicblaze.com/)
Blog: http://gnodet.blogspot.com/
