I don't think we can even if we wanted to. Their annotation jar is a random collection of annotation classes from various specs:

javax/annotation/Generated.class
javax/annotation/PostConstruct.class
javax/annotation/PreDestroy.class
javax/annotation/Resource$AuthenticationType.class
javax/annotation/Resource.class
javax/annotation/Resources.class
javax/annotation/security/DeclareRoles.class
javax/annotation/security/DenyAll.class
javax/annotation/security/PermitAll.class
javax/annotation/security/RolesAllowed.class
javax/annotation/security/RunAs.class
javax/ejb/EJB.class
javax/ejb/EJBs.class
javax/persistence/PersistenceContext$PersistenceContextType.class
javax/persistence/PersistenceContext.class
javax/persistence/PersistenceContexts.class
javax/persistence/PersistenceUnit.class
javax/persistence/PersistenceUnits.class
javax/xml/ws/WebServiceRef.class
javax/xml/ws/WebServiceRefs.class

I find it very strange.

-dain

On May 23, 2007, at 1:38 PM, David Jencks wrote:

I haven't investigated the actual history but I think our annotation api jar was implemented independently of theirs so I am very reluctant to discard ours for theirs.

thanks
david jencks

On May 23, 2007, at 12:19 PM, Dain Sundstrom wrote:

IIRC the Tomcat has some non-compliant spec jars. Specifically, the annotations-api.jar is not correct... it has javax/persistence/ PersistenceContext$PersistenceContextType.class, but that class is not an inner class and should be javax.persistence.PersistenceContextType

I'm guessing there are other problems with that jar and based on that I am concerned about the other spec jars they have. Have we run the signature tests on these jars?

Paul, I don't follow the tomcat list, so can you mention the bad code to them? Apache isn't allowed to ship non compliant implementations of specs.

Thanks,

-dain

On May 23, 2007, at 8:16 AM, Paul McMahan wrote:

Geronimo's servlet 2.5, jsp 2.1, and EL 1.0 specs were copied from tomcat6. This was done because geronimo needed them for JEE5 but the tomcat team had not made those spec jars available in a maven repo. See discussion at http://tinyurl.com/yvtj3f

Since that time there have been some concerns raised on [EMAIL PROTECTED] about ASF maintaining multiple copies of these specs, and at least one geronimo has expressed frustration about drift between the two versions.

Now thanks to Filip Hanik's efforts tomcat's JEE api jars are now available at the maven central repo. If I verify that that these don't break TCK then are there any concerns with using them in geronimo 2.0 and deleting geronimo's copy of these specs from SVN?


Best wishes,
Paul



Reply via email to