Congratulations Guillaume! Keep up the good work ;)
gnodet wrote: > > Sorry, the week has been quite busy (I have just had my fifth child) ... > > On 5/31/07, Eduardo Burgos <[EMAIL PROTECTED]> wrote: >> >> any news? >> >> >> On 5/24/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: >> > >> > On 5/23/07, Eduardo Burgos <[EMAIL PROTECTED]> wrote: >> > > >> > > JIRA for the custom serviceUnitAnalyzer in jbi-maven-plugin: >> > > >> > > https://issues.apache.org/activemq/browse/SM-956 >> > > >> > > JIRA for the BeanServiceUnitAnalyzer for the servicemix-bean >> component: >> > > >> > > https://issues.apache.org/activemq/browse/SM-957 >> > >> > >> > Thanks ! I'll take a look at these asap. >> > >> > Regarding the BeanServiceUnitAnalyzer, I only implemented it for >> endpoints >> > > of type <bean:endpoint> (I just thought this would be the most common >> > > case). >> > > I generated the consumes by looking at the fields with >> @ExchangeTarget >> > > using >> > > reflection. >> > >> > >> > Yeah, I guess this is the most common use cases. >> > >> > Please take a look. >> > > >> > > >> > > Eduardo Burgos >> > > >> > > >> > > On 5/23/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: >> > > > >> > > > On 5/23/07, Eduardo Burgos <[EMAIL PROTECTED]> wrote: >> > > > > >> > > > > No, I'm not thinking about removing the other way, it's just to >> have >> > > > this >> > > > > as >> > > > > an option. >> > > > > About the custom service analyzer, for example, lets say we have >> a >> > > > > component >> > > > > that is not supported by this team and we have no possibility to >> > > access >> > > > > it's >> > > > > source code and I still need to build a service unit for it, >> > currently >> > > > > there >> > > > > is no possibility for the jbi-maven-plugin to guess an analyzer >> for >> > > it, >> > > > so >> > > > > I >> > > > > thought that if we had the option to define the analyzer class at >> > > > service >> > > > > unit level it should do. >> > > > >> > > > >> > > > Yeah, I was thinking about that too. >> > > > >> > > > Another example is what I need right now, I'm looking to develop a >> > > > > servicemix-bean SU and I couldn't find a ServiceUnitAnalyzer for >> > that >> > > > > component. I couldn't have solved my problem in a standard way if >> I >> > > > don't >> > > > > have access to this mailing list :) >> > > > >> > > > >> > > > Agreed >> > > > >> > > > I have it set in my servicemix source and its ready for a diff and >> > JIRA. >> > > > > Working on the BeanSUAnalyzer as we speak :) >> > > > >> > > > >> > > > Cool, thx ! >> > > > >> > > > Eduardo Burgos >> > > > > >> > > > > On 5/23/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: >> > > > > > >> > > > > > Sure, sounds good ! >> > > > > > What kind of custom service analyser are thinking about ? >> > > > > > Or is that for non servicemix components ? >> > > > > > >> > > > > > But I don't think we should remove the other way, which work >> > > > > > well for servicemix components. >> > > > > > >> > > > > > Btw, such discussions about enhancing ServiceMix should really >> > > > > > take place on the dev list, so please answer to the dev list >> > > > > > if possible. >> > > > > > >> > > > > > On 5/23/07, Eduardo Burgos <[EMAIL PROTECTED]> wrote: >> > > > > > > >> > > > > > > There is something else I would like to suggest. >> > > > > > > >> > > > > > > Let's say I have a service-unit artifact and my target >> component >> > > > does >> > > > > > not >> > > > > > > have a serviceUnitAnalyzer, I've seen the logic on the >> > > > > jbi-maven-plugin >> > > > > > > and >> > > > > > > how it uses the serviceUnitAnalyzer and I noticed that it >> either >> > > > uses >> > > > > > that >> > > > > > > jbi-services.xml file or looks up the target component for a >> > > > > > > serviceUnitAnalyzer class name. >> > > > > > > What if we also have a >> > > > > > > <serviceUnitAnalyzerClass></serviceUnitAnalyzerClass> >> > > > > > > declared in that service-unit artifact (not the component) >> where >> > I >> > > > can >> > > > > > > specify my desired serviceUnitAnalyzer for that SU. Example: >> > > > > > > >> > > > > > > <project ..... >> > > > > > > <artifactId>myproject</artifactId> >> > > > > > > <packaging>jbi-service-unit</packaging> >> > > > > > > <build> >> > > > > > > <plugins> >> > > > > > > <plugin> >> > > > > > > <groupId>org.apache.servicemix.tooling >> </groupId> >> > > > > > > <artifactId>jbi-maven-plugin</artifactId> >> > > > > > > <version>${servicemix-version}</version> >> > > > > > > <configuration> >> > > > > > > <serviceUnitAnalyzerClass> >> > > org.test.jbi.bean.BeanServiceUnitAnalyzer >> > > > > > > </serviceUnitAnalyzerClass> >> > > > > > > </configuration> >> > > > > > > </plugin> >> > > > > > > </plugins> >> > > > > > > </build> >> > > > > > > >> > > > > > > Notice that the <serviceUnitAnalyzerClass> is in the SU's >> > > > > configuration >> > > > > > > and >> > > > > > > not the component, this way the desired serviceUnitAnalyzer >> is >> > not >> > > > > tied >> > > > > > to >> > > > > > > the component but to the plugin's configuration (And also >> > keeping >> > > > the >> > > > > > > current approach). >> > > > > > > >> > > > > > > >> > > > > > > Then in the >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> org.apache.servicemix.maven.plugin.jbi.GenerateServiceUnitDescriptorMojoclass >> > > > > > > add a String field called 'serviceUnitAnalyzerClass' and >> insert >> > > this >> > > > > > > where it finds the serviceUnitAnalyzer class: >> > > > > > > >> > > > > > > if (useServiceUnitAnalyzer.booleanValue()) { >> > > > > > > + if (serviceUnitAnalyzerClass!= null) >> > > > > > > + return serviceUnitAnalyzerClass; >> > > > > > > MavenProject project = >> > > > getComponentProject(); >> > > > > > > >> > > > > > > >> > > > > > > Does this makes sense? >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > Eduardo Burgos >> > > > > > > >> > > > > > > >> > > > > > > On 5/22/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote: >> > > > > > > > >> > > > > > > > Yeah, it's missing. >> > > > > > > > Feel free to attach one to a JIRA :-) >> > > > > > > > >> > > > > > > > On 5/23/07, Eduardo Burgos <[EMAIL PROTECTED]> wrote: >> > > > > > > > > >> > > > > > > > > Is there a ServiceUnitAnalyzer for this component? if >> not, >> > can >> > > I >> > > > > > > provide >> > > > > > > > > one? >> > > > > > > > > >> > > > > > > > > Eduardo Burgos >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > -- >> > > > > > > > Cheers, >> > > > > > > > Guillaume Nodet >> > > > > > > > ------------------------ >> > > > > > > > Principal Engineer, IONA >> > > > > > > > Blog: http://gnodet.blogspot.com/ >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > Cheers, >> > > > > > Guillaume Nodet >> > > > > > ------------------------ >> > > > > > Principal Engineer, IONA >> > > > > > Blog: http://gnodet.blogspot.com/ >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > Cheers, >> > > > Guillaume Nodet >> > > > ------------------------ >> > > > Principal Engineer, IONA >> > > > Blog: http://gnodet.blogspot.com/ >> > > > >> > > >> > >> > >> > >> > -- >> > Cheers, >> > Guillaume Nodet >> > ------------------------ >> > Principal Engineer, IONA >> > Blog: http://gnodet.blogspot.com/ >> > >> > > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Principal Engineer, IONA > Blog: http://gnodet.blogspot.com/ > > -- View this message in context: http://www.nabble.com/Re%3A-servicemix-bean%2C-ServiceUnitAnalyzer-tf3804735s12049.html#a10908457 Sent from the ServiceMix - Dev mailing list archive at Nabble.com.
