Can you paste me one of the corrupted web.xml files please?
--jason
On Jun 6, 2007, at 10:20 AM, Donald Woods wrote:
The fragment and <configuration> is in the code in trunk right now,
which is causing my build failures on WinXP, but not SLED10/SLES10....
The error I'm seeing, is when the CAR files are created, because
the jspc updated web.xml files have duplicate <webapp> entries. It
seems that where the Fragment comment is located in the source
web.xml, the jspc plugin is placing a complete copy of its updated
web.xml where the comment is, which creates a web.xml with 2
<webapp> sections and causes the CAR build to fail with a XML
parsing error.
I don't have a build output to paste here, as I'm testing a build
that has the fragment comments and <configuration> code removed to
verify it works on WinXP and SLED10....
-Donald
Anita Kulshreshtha wrote:
Donald,
If you add the <configuration> and the fragment comment, can you
reproduce the error? Do you see the error mentioned in this thread
or a
NCDFE o.a.AnnotationProcessor.
Thanks
Anita
--- Paul McMahan <[EMAIL PROTECTED]> wrote:
Strange, I don't understand why we're seeing inconsistent
behavior across different environments. Should be OK to go
ahead and commit your further refinements to how we invoke the
plugin and then let's keep an eye on it.
Best wishes,
Paul
On Jun 6, 2007, at 11:34 AM, Donald Woods wrote:
These changes are actually breaking my builds on WinXP w/ Sun
1.5.0_11 and Maven 2.0.6 now for the Tomcat config of geronimo-
welcome app.
If I remove the added <configuration> attributes from jspc-
maven- plugin, remove the Fragment comment from the web.xml
source and use
the 20070603 snapshot of jspc-maven-plugin, then it builds fine
again....
-Donald
Paul McMahan wrote:
On Jun 5, 2007, at 4:37 PM, Jason Dillon wrote:
Why would Geronimo fail to parse an xml file with a valid xml
comment?
Good question. I should be able to revert locally and
recreate the error if you'd like to see some more data.
There was a bug in the first 2.0-SNAPSHOT of the jspc-maven-
plugin which may have caused the generated web.xml to be corrupt,
but I've fixed that.
I don't believe that the previous version of the plugin defaulted
the injectString to <!-- [INSERT FRAGMENT HERE] --> though...
unless it was removed in the trunk version which was what I based
the new version on. As I mentioned before, the default
injectString was '</web-app>' and I left it that way.
I didn't look at the source for the previous version. My comments
about it were based on a conversation I had on IRC. At any
rate, specifying the placeholder string is consistent with the
plugin doc at:
http://mojo.codehaus.org/jspc-maven-plugin/usage.html
and resolved the compile error for those unfortunate souls
that encountered it.
Best wishes,
Paul
_____________________________________________________________________
_______________
Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see
what's on, when. http://tv.yahoo.com/collections/222
