[ 
https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Jencks reopened GERONIMO-2735:
------------------------------------


This needs some cleanup.

1. All the variables except portOffset start with "Plan" which is not 
appropriate
2. both environment variables and system properties are just stuffed into the 
substitution list willy-nilly.  This could easily let other peoples settings 
interfere with geronimo.  Our properties should start with an unambiguous 
prefix such as org.apache.geronimo.config.substitution.

> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
>                 Key: GERONIMO-2735
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2735
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.1.1, 1.1.x, 2.0-M1
>         Environment: All
>            Reporter: Ted Kirby
>            Assignee: David Jencks
>            Priority: Minor
>             Fix For: 2.0-M6
>
>         Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file.  In that file, allow something like 
> this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
>     <gbean name="TomcatConnector">
>         <attribute name="port">${tomcat.port}</attribute>
>         <attribute name="host">${tomcat.listen.ip}</attribute>
>    </gbean>
> </module>
> The server reads the property file on boot (if one exists).  When the 
> config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to