[
https://issues.apache.org/jira/browse/GERONIMO-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516425
]
David Jencks commented on GERONIMO-3359:
----------------------------------------
It's more or less by design although we might be able to find a way to change
the architecture to eliminate duplication of actually constructing the
references. Each builder (web module builder, MyFacesMBE, JspMBE) are looking
at different annotations and adding xml to the
gradually-getting-more-metadata-complete spec dd so they call the
NamingBuilders to add the xml and turn it into references.
I think to fix this we'd have to add another phase to the NamingBuilder
interface to process annotations, and call that one from each MBE and call the
buildNaming method only from the ModuleBuilder.
> naming builders are invoked twice
> ---------------------------------
>
> Key: GERONIMO-3359
> URL: https://issues.apache.org/jira/browse/GERONIMO-3359
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.0
> Reporter: Jarek Gawor
>
> I have a simple web.xml with one service-ref entry. However, I'm seeing that
> the code that creates the service ref is called twice with the same
> information.
> From the configuration and the code it looks like
> MyFacesModuleBuilderExtension.addGBeans() and
> JspModuleBuilderExtension.addGBeans() methods call
> namingBuilders.buildNaming(webApp, jettyWebApp, webModule, buildingContext);.
> But for web applications,
> AbstractWebModuleBuilder.configureBasicWebModuleAttributes() already does
> that.
> Not sure if this is by design or a mistake.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
