This work is complete now and available in trunk and the 2.0 branch.
As a side effect of introducing these new connectors we needed to
make some changes to the management apis (mainly WebManager) to allow
the connectors to specify which attributes they support, what their
types are (string, boolean, integer, etc), whether or not they are
required vs. optional, etc. All this used to be hard coded in the
portlet but now they are defined per connector type in
JettyManagerImpl and TomcatManagerImpl and the portlet just renders a
form with corresponding inputs and validation.
I tried to cover as much testing as possible within our proposed
timeframe for 2.0 but there may still be some rough edges. In
particular I was not able to test the APR connectors without having
the native libraries. You can successfully create an APR connector
but without the libraries it won't start due to an unsatisfied link
error (as expected).
Thanks to Jeff and David Jencks for all their help on getting this
important feature into 2.0.
Best wishes,
Paul
On Jul 25, 2007, at 1:43 PM, Jeff Genender wrote:
Ok I added a whole bunch of new connectors in the o.a.g.t.connectors
package.
I am still working on APR - more notes to follow on this as its a
little
squirly since the Tomcat Connector somewhat "chooses" this
automatically
based on the existence of a native libraries. For the console we may
wish to do a check on whether the native libs exist, and if so,
present
the APR connector. More on this in another email.
Here are the connectors we care about at the moment...
AJP13ConnectorGBean - Implements AJP
Http11ConnectorGBean - Implements blocking Http connector
Https11ConnectorGBean - Implements blocking Https connector
Http11NIOConnectorGBean - Implements non-blocking Http connector
Https11NIOConnectorGBean - Implements non-blocking Https connector
I have not wired them into the container and other GBeans yet...I want
to clena them up and get any feedback before making the switch since
this obviously will impact the console upon wiring them in.
As a side note...I am not using any references to the WebManager or
other interfaces we used that hooked into the console. We can re-add
those if those are deemed necessary.
Jeff
Paul McMahan wrote:
I agree NIO support would be great to have in 2.0, especially
since its
required for comet.
Best wishes,
Paul
On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote:
Hi,
I was going through some JIRAs and the Geronimo2.0 source and
noticed it
will be difficult at best to get the NIO connector and setting
attributes on the APR connector for Tomcat due to its current
implementation. I really think the ability to use these 2
connectors is
very important for the 2.0 release and I would like to put these
in. If
there are no objections, I would like this to be a part of the 2.0
release.
Jeff
