[ 
https://issues.apache.org/jira/browse/GERONIMO-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529272
 ] 

Joe Bohn commented on GERONIMO-2775:
------------------------------------

Thanks for providing the patch.  It would be great to get the web stats working 
on Jetty again since we've moved to Jetty 6.  However, there are two main 
concerns I have with this patch.

- The enable/disable capability is removed which means that the stats will 
always be running in jetty potentially impacting the system performance.
- More significant than that is the fact that this patch puts a hard dependency 
between console-standard and the geronimo-jetty6 module. There are classes from 
the jetty6 implementation directly included in the console.  That means that 
when the console plugin is created it will have a dependency on geronimo-jetty 
and pull it along even in the tomcat installation.   The console can do things 
to detect the web container and act appropriately but the console web app 
itself should not pull in jetty or tomcat elements directly.



> Enabling web statistics collection for jetty fails from the admin console
> -------------------------------------------------------------------------
>
>                 Key: GERONIMO-2775
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2775
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console, Jetty
>    Affects Versions: 2.0.x
>         Environment: 2.0-SNAPSHOT jetty6 jee5 assembly
>            Reporter: Paul McMahan
>            Assignee: Joe Bohn
>         Attachments: geronimo-2775.patch, geronimo-2775.patch, 
> geronimo-2775.patch
>
>
> in the Web Server Manager portlet in the jetty assembly click on the "enable" 
> link for enabling statistics collection.  The click is ignored.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to