car file left over after failed deployment
------------------------------------------

                 Key: GERONIMO-3488
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3488
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: deployment
    Affects Versions: 2.0.1
            Reporter: David Jencks


I just found one circumstance where a failed deployment leaves behind a car 
file preventing redeployment.  If the deploy operation succeeds but verifying 
it fails.... bad news.

Deployer.java around line 308:

            DeploymentContext context = builder.buildConfiguration(inPlace, 
configID, plan, module, stores, artifactResolver, store);
            List configurations = new ArrayList();
            boolean configsCleanupRequired = false;
            configurations.add(context.getConfigurationData());
            configurations.addAll(context.getAdditionalDeployment());


The next to last line attempts to verify the deployment, and throws a 
DeploymentException if it fails.  I think the try { on line 322 should be moved 
earlier to account for this case.  I think all that's created is the directory 
to put the car in... but that's enough to prevent future deployments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to