On Thu, Oct 07, 2004 at 04:52:28PM -0400, Allan Edwards wrote: > This set of changes gets rid of most of the libhttpd > 64bit warnings on Windows at the cost of several httpd > API changes. I defined AP_INT_TRUNC_CAST for use where > there are size mismatches with APR API's (those APR > API's will need to be updated in APR 2.0)
Again I think the use of the macro is really ugly. > -AP_DECLARE(int) ap_rputs(const char *str, request_rec *r); > +AP_DECLARE(apr_size_t) ap_rputs(const char *str, request_rec *r); The ap_r* changes are not safe: these functions return negative values on error. Each and every int->size_t conversion needs to be carefully checked for this kind of issue. joe
