> From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 09, 2005 6:20 PM
[...] > Hence, the response headers from the origin server on a 304 response aren't > guaranteed to be complete. So, what this commit does now is load in the > stored cached response headers and interleaving them with the headers we > just received as part of the 304 response - retaining the just-received > headers if there is overlap. Then, we're updating our cache entry with this > new merged set of headers. Yeah, I misread the comment. > The issue here is that you can't just take the response headers from a 304 > header and use them and them alone to update the cache: you need to 'merge' > in what you already have to be complete. Sure. > As an aside, see line 934 in modules/http/http_filters.c for what httpd sends > on a 304: all other header fields are stripped. Ah yes, makes sense. Nice to have a guard on the way out. > Or, do you see a better way? Or, is there a way to make the comment clearer? I think I've clarified the comment slightly in rev 153104. But honestly, it was just me. Sander
