Ruediger Pluem wrote: > Would the following change in mod_cache.h require a major bump or would a > minor bump be enough? > > APR_DECLARE_OPTIONAL_FN(apr_status_t, > ap_cache_generate_key, > - (request_rec *r, apr_pool_t*p, char**key )); > + (request_rec *r, apr_pool_t*p, char**key, > cache_request_rec *cache));
That one is a major bump by definition, you broke, you didn't enhance ABI. > Or do we need no bump at all as we currently do not install mod_cache.h in > the includes directory > and thus all things defined in mod_cache.h can be considered private? I'll agree with Joe on this, that since mod_cache.h isn't really a public interface yet. But we better put a big red warning in CHANGES that we broke any third party caching modules or providers.