On Fri, Feb 27, 2009 at 2:55 AM, Bertrand Mansion <bmans...@mamasam.net> wrote:
> By the way, for content-type, the dispatch function at the moment is:
> if (0 == apr_strnatcmp("content_type", key)) {
> const char *value = luaL_checkstring(L, 3);
> r->content_type = apr_pstrdup(r->pool, value);
> luaL_getmetatable(L, "Apache2.Request");
> lua_pushstring(L, value);
> lua_setfield(L, -2, "content_type");
> lua_pop(L, 1);
> return 0;
> }
> Shouldn't it use ap_set_content_type() instead ?
It should, in fact, thanks. Just checked in the change.
> And I find it weird that, now, to get 'document root', you have to
> call r:document_root() instead of r.document_root as it was before.
> That's because the dispatch is set like this:
> apr_hash_set(dispatch, "document_root", APR_HASH_KEY_STRING,
> makefun(&req_document_root, APL_REQ_FUNTYPE_LUACFUN, p));
>
> It could be just:
> apr_hash_set(dispatch, "document_root", APR_HASH_KEY_STRING,
> makefun(&req_content_encoding_field, APL_REQ_FUNTYPE_STRING,
> p));
Agreed, this is much nicer syntax. Applied this change as well. Thanks!
>
> --
> Bertrand Mansion
> Mamasam
>
