Re: svn commit: r1433682 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/worker/worker.c

[Graham Leggett]

On 15 Jan 2013, at 11:53 PM, jaillet...@apache.org wrote:

>     if (ap_thread_stacksize != 0) {
> -        apr_threadattr_stacksize_set(thread_attr, ap_thread_stacksize);
> +        rv = apr_threadattr_stacksize_set(thread_attr, ap_thread_stacksize);
> +        if (rv != APR_SUCCESS && rv != APR_ENOTIMPL) {
> +            ap_log_error(APLOG_MARK, APLOG_WARNING, rv, ap_server_conf, 
> APLOGNO(02436)
> +                         "WARNING: ThreadStackSize of %" APR_SIZE_T_FMT " is 
> "
> +                         "inappropriate, using default", 
> +                         ap_thread_stacksize);
> +        }
>     }

Would it be possible to update the message so that it is more specific? 
"inappropriate" doesn't tell the admin enough to get a clear understanding of 
what they have to do to fix it.

Regards,
Graham
--